Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relationship parameters sync_backref and omit_join #169

Closed
wants to merge 2 commits into from

Conversation

Spindel
Copy link

@Spindel Spindel commented Jul 31, 2020

These new keyword arguments were added in SQLAlchemy 1.3.17

@Spindel
Copy link
Author

Spindel commented Jul 31, 2020

Build fails due to pytest 6.0 deprecating functionality that's used upstream. Downgrading pytest to < 6.0 will fix that, but that kind of change isn't suitable for this PR.

@Spindel
Copy link
Author

Spindel commented Jul 31, 2020

CLA signed by company as well.

omit_join can technically only be "None" or "False".
The new resolver in pip doesn't like forked packages with the same versions as
those published, so I'm hijacking a micro version here to force an upgrade.

All Software Sucks.
@Spindel Spindel force-pushed the sqlalchemy-relationship-1.3 branch from 116b9a2 to f9ded62 Compare January 15, 2021 15:49
@Spindel
Copy link
Author

Spindel commented Jan 15, 2021

Updated this branch against current master.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Spindel
Copy link
Author

Spindel commented Apr 17, 2022

CLA was signed, but it took years to get back to me about this, closing as the project is clearly abandoned.

@Spindel Spindel closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants