feat(client): upload images client flow with s3 presigned #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmho
commented
Dec 9, 2024
| @@ -31,6 +31,6 @@ watch: | |||
| # Generates the client SDK from the server's current OpenAPI spec. | |||
| gen: | |||
| @$(MAKE) -C api openapi | |||
| @orval --input ./api/openapi.yaml --output ./client-v2/gen/openapi.ts | |||
| @orval --input ./api/openapi.yaml --output ./client-v2/lib/api/happened.ts | |||
There was a problem hiding this comment.
Add to a lib/api folder for to improve semantics.
anmho
commented
Dec 9, 2024
| @@ -109,12 +109,13 @@ func main() { | |||
| } | |||
| logger.Info("successfully pinged db") | |||
|
|
|||
| cfg, err := awsConfig.LoadDefaultConfig(ctx) | |||
| cfg, err := awsConfig.LoadDefaultConfig(ctx, awsConfig.WithRegion("us-west-2")) | |||
There was a problem hiding this comment.
Force us-west-2 but this should be an environment variable.
anmho
commented
Dec 9, 2024
| @@ -94,6 +96,6 @@ func registerRoutes( | |||
| }, | |||
| }, protectedGreetHandler()) | |||
|
|
|||
| huma.Get(api, "/create-upload-url", CreateUploadURLHandler(imageService)) | |||
| huma.Post(api, "/create-upload-url", CreateUploadURLHandler(imageService)) | |||
There was a problem hiding this comment.
Post since we are created a presigned upload url resource.
anmho
commented
Dec 9, 2024
| @@ -63,7 +63,7 @@ export default function Page() { | |||
|
|
|||
| if (completeSignIn.status === "complete") { | |||
| await setActive({ session: completeSignIn.createdSessionId }); | |||
| router.replace("/(home)"); | |||
| router.replace("/(tabs)"); | |||
There was a problem hiding this comment.
Navigate to tabs layout as the home.
anmho
commented
Dec 9, 2024
| // Queries | ||
| const { isPending: isUploadPending, mutateAsync: uploadImagesMutation } = | ||
| useMutation({ | ||
| mutationFn: uploadImages, |
There was a problem hiding this comment.
Upload/create journey tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented client using React-Query.
Used a Promise.all approach and displayed upload state to the user.
Updated http method to from GET to POST for
/create-upload-url