Add Faker::Fantasy::Tolkien (faker-ruby#2152)

* Combine lotr and hobbit into tolkien .yml

* Add tolkien characters

* Restore hobbit and lotr movie yamls

* Fix generator to use new legendarium class

* Combine hobbit and lotr yml into legendarium yml

* Add indentation to yaml array list items

Also, do not wrap lines at 81 chars (Pysch default)

* Point tolkien movies to default lengendarium yml

* Remove silly comment

* Use consistent quotations. Unbreak lines.

* Alias 'movie' classes. Point to new yaml file name

* Add tests

* Fix formatting and documentation

* Re-namespace to fantasy/tolkien

lib/faker/fantasy/tolkien.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module Faker
+  class Fantasy
+    class Tolkien < Base
+      flexible :tolkien
+
+      class << self
+        ##
+        # Produces a character from Tolkien's legendarium
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Fantasy::Tolkien.character
+        #    #=> "Goldberry"
+        #
+        # @faker.version next
+        def character
+          fetch('tolkien.characters')
+        end
+
+        ##
+        # Produces a location from Tolkien's legendarium
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Fantasy::Tolkien.location
+        #    #=> "Helm's Deep"
+        #
+        # @faker.version next
+        def location
+          fetch('tolkien.locations')
+        end
+
+        ##
+        # Produces a race from Tolkien's legendarium
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Fantasy::Tolkien.race
+        #     #=> "Uruk-hai"
+        #
+        # @faker.version next
+        def race
+          fetch('tolkien.races')
+        end
+
+        ##
+        # Produces the name of a poem from Tolkien's legendarium
+        #
+        # @return [String]
+        #
+        # @example
+        #   Faker::Fantasy::Tolkien.poem
+        #     #=> "Chip the glasses and crack the plates"
+        #
+        # @faker.version next
+        def poem
+          fetch('tolkien.poems')
+        end
+      end
+    end
+  end
+end

lib/faker/movies/hobbit.rb

@@ -14,7 +14,7 @@ class << self
         #
         # @faker.version 1.8.0
         def character
-          fetch('hobbit.character')
+          fetch('tolkien.hobbit.character')
         end
 
         ##
@@ -27,7 +27,7 @@ def character
         #
         # @faker.version 1.8.0
         def thorins_company
-          fetch('hobbit.thorins_company')
+          fetch('tolkien.hobbit.thorins_company')
         end
 
         ##
@@ -41,7 +41,7 @@ def thorins_company
         #
         # @faker.version 1.8.0
         def quote
-          fetch('hobbit.quote')
+          fetch('tolkien.hobbit.quote')
         end
 
         ##
@@ -54,7 +54,7 @@ def quote
         #
         # @faker.version 1.8.0
         def location
-          fetch('hobbit.location')
+          fetch('tolkien.hobbit.location')
         end
       end
     end

lib/faker/movies/lord_of_the_rings.rb

@@ -14,7 +14,7 @@ class << self
         #
         # @faker.version 1.7.0
         def character
-          fetch('lord_of_the_rings.characters')
+          fetch('tolkien.lord_of_the_rings.characters')
         end
 
         ##
@@ -27,7 +27,7 @@ def character
         #
         # @faker.version 1.7.0
         def location
-          fetch('lord_of_the_rings.locations')
+          fetch('tolkien.lord_of_the_rings.locations')
         end
 
         ##
@@ -41,7 +41,7 @@ def location
         #
         # @faker.version 1.9.0
         def quote
-          fetch('lord_of_the_rings.quotes')
+          fetch('tolkien.lord_of_the_rings.quotes')
         end
       end
     end