Merge pull request #15 from rootty/dev

Use string instead of integer for id.
drudge · Mar 19, 2016 · be9ec1b · be9ec1b
2 parents c7735b1 + 02e4522
commit be9ec1b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -92,7 +92,7 @@ export default class TwitterTokenStrategy extends OAuthStrategy {
         let json = JSON.parse(body);
         let profile = {
           provider: 'twitter',
-          id: json.id,
+          id: json.id_str ? json.id_str : String(json.id),
           username: json.screen_name,
           displayName: json.name,
           name: {

diff --git a/test/fixtures/profile.js b/test/fixtures/profile.js
@@ -1,5 +1,6 @@
 export default JSON.stringify({
-  id: '1234',
+  id: 710474596655480832,
+  id_str: '710474596655480832',
   screen_name: 'ghaiklor',
   name: 'Eugene Obrezkov',
   profile_image_url_https: 'IMAGE_URL'

diff --git a/test/unit/index.test.js b/test/unit/index.test.js
@@ -198,7 +198,7 @@ describe('TwitterTokenStrategy:userProfile', () => {
       if (error) return done(error);
 
       assert.equal(profile.provider, 'twitter');
-      assert.equal(profile.id, '1234');
+      assert.equal(profile.id, '710474596655480832');
       assert.equal(profile.username, 'ghaiklor');
       assert.equal(profile.displayName, 'Eugene Obrezkov');
       assert.deepEqual(profile.photos, [{value: 'IMAGE_URL'}]);