This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
Issue #2671914: Implement EB configuration UI #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primsi
force-pushed
the
2671914_conf_ui
branch
from
0db207c to
32dc164
Compare
| public function buildConfigurationForm(array $form, FormStateInterface $form_state) { | ||
| $configuration = $this->getConfiguration(); | ||
| $settings = $configuration['settings']; | ||
| $form += parent::buildConfigurationForm($form, $form_state); |
There was a problem hiding this comment.
Parent is WidgetBase, which doesn't do anything in buildConfigurationForm(). Only description is added here, but we have few more configuration options in defaultConfiguration(), which we would need to handle.
| if (!empty($values['max_filesize'])) { | ||
| $this->configuration['max_filesize'] = $values['max_filesize'] . 'M'; | ||
| } | ||
| } |
There was a problem hiding this comment.
None of the other options are mentioned in this method, and in my testing, any changes I made to them were not saved.
There was a problem hiding this comment.
It might be possible to rely on default submit implementation. See \Drupal\entity_browser\PluginConfigurationFormTrait
primsi
force-pushed
the
2671914_conf_ui
branch
3 times, most recently
from
523c740 to
5c712e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.