Skip to content
This repository has been archived by the owner on Apr 4, 2018. It is now read-only.

Upgrade to 2.0 #17

Merged
merged 59 commits into from
May 16, 2013
Merged

Upgrade to 2.0 #17

merged 59 commits into from
May 16, 2013

Conversation

dryan
Copy link
Owner

@dryan dryan commented May 16, 2013

This is a near complete code refactor to bring the module back into conformance with the canonical ruby gem.

The ruby gem changed how HitHighlighter.hit_highlight works. The query parameter from v1.x must now be passed as a named argument and not a positional argument. The positional argument is now an array of arrays of indices indicating where to place the highlight tags, ie [[0,4]]. These indices are based on the text with all HTML tags stripped. Additionally, the option for customizing what HTML tag to use as the highlight has changed to tag.

Tests for Validation are skipped on narrow builds of python (which includes the system and homebrew-installed versions on OS X), though the validation methods will work on these systems.

Parsing extended Kanji characters on narrow build systems works in all tests, but my fail in some cases. Usage of this module for work with extended unicode characters is only recommended on wide builds of python.

dryan added 30 commits May 1, 2013 17:48
…he tests have incorrect html attribute sorting
dryan added 22 commits May 14, 2013 10:14
…erlapping_entities since it's a private method
…dded since none of the canonical libraries have implemented it yet
@ghost ghost assigned dryan May 16, 2013
dryan added a commit that referenced this pull request May 16, 2013
@dryan dryan merged commit d2f4f9d into master May 16, 2013
@dryan dryan deleted the dryan/updating-regexes branch May 16, 2013 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant