This repository has been archived by the owner on Apr 4, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he tests have incorrect html attribute sorting
…erlapping_entities since it's a private method
…dded since none of the canonical libraries have implemented it yet
…s-ish compatibility
…wide/narrow issue anyway
ghost
assigned dryan
May 16, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a near complete code refactor to bring the module back into conformance with the canonical ruby gem.
The ruby gem changed how HitHighlighter.hit_highlight works. The
query
parameter from v1.x must now be passed as a named argument and not a positional argument. The positional argument is now an array of arrays of indices indicating where to place the highlight tags, ie[[0,4]]
. These indices are based on the text with all HTML tags stripped. Additionally, the option for customizing what HTML tag to use as the highlight has changed totag
.Tests for Validation are skipped on narrow builds of python (which includes the system and homebrew-installed versions on OS X), though the validation methods will work on these systems.
Parsing extended Kanji characters on narrow build systems works in all tests, but my fail in some cases. Usage of this module for work with extended unicode characters is only recommended on wide builds of python.