-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response body respond to each for 1.9 #2
Conversation
+1 for this |
+1 |
+1 this follows Rack's spec and shouldn't break previous version |
+1 |
2 similar comments
+1 |
+1 |
Please consider merging, this is a blocking issue on Ruby 1.9, see #6 |
Please merge! I confirm this patch fixes the issue for us. |
+1 |
1 similar comment
+1 |
Worth mentioning for people leaving +1's here who may not find them otherwise: there are a few forks out there that incorporate this fix as well as others. @karmi has one that includes nothing new but this bugfix. Mine includes some additional features and is still being actively maintained (albeit at a pretty slow pace). I believe there are a few other forks out there too, if you dig around. |
Fixed Rack::Throttle::Limiter#http_error for Ruby 1.9 compatibility.
Per the spec, "The Body itself should not be an instance of String, as this will break in Ruby 1.9." This patches Rack::Throttle::Limiter#http_error to return an array of strings.