Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response body respond to each for 1.9 #2

Merged
merged 1 commit into from
Nov 13, 2014
Merged

Conversation

tjsingleton
Copy link

Per the spec, "The Body itself should not be an instance of String, as this will break in Ruby 1.9." This patches Rack::Throttle::Limiter#http_error to return an array of strings.

@mid
Copy link

mid commented Mar 13, 2011

+1 for this

@phlipper
Copy link

+1

@alexchee
Copy link

alexchee commented Nov 9, 2011

+1 this follows Rack's spec and shouldn't break previous version

@paveltyk
Copy link

paveltyk commented Feb 6, 2012

+1

2 similar comments
@tpitale
Copy link

tpitale commented Mar 24, 2012

+1

@ihower
Copy link

ihower commented May 24, 2012

+1

@karmi
Copy link
Contributor

karmi commented Jul 15, 2012

Please consider merging, this is a blocking issue on Ruby 1.9, see #6

bensomers referenced this pull request in bensomers/improved-rack-throttle Oct 5, 2012
#1: fix bug that prevented making changes to the parameters
#2: fix bug that allowed buckets to overfill, 
causing them to empty too slowly and wind up punishing
offenders in proportion to how badly they offended
(instead of capping out the punishment at a certain
level)
@djones
Copy link

djones commented Nov 22, 2012

Please merge! I confirm this patch fixes the issue for us.

@sideshow
Copy link

sideshow commented Dec 8, 2012

+1

1 similar comment
@redbar0n
Copy link

redbar0n commented Dec 2, 2013

+1

@bensomers
Copy link

Worth mentioning for people leaving +1's here who may not find them otherwise: there are a few forks out there that incorporate this fix as well as others. @karmi has one that includes nothing new but this bugfix. Mine includes some additional features and is still being actively maintained (albeit at a pretty slow pace). I believe there are a few other forks out there too, if you dig around.

artob added a commit that referenced this pull request Nov 13, 2014
Fixed Rack::Throttle::Limiter#http_error for Ruby 1.9 compatibility.
@artob artob merged commit c070e86 into dryruby:master Nov 13, 2014
@artob artob self-assigned this Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.