-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Dockerhub API to poll for digest change #19
Conversation
f6f41c5
to
ec25202
Compare
bf322dd
to
ba5b63c
Compare
ba5b63c
to
6ad435a
Compare
Also tried to get integration test to run in CI. The main difficulty is to run Docker-in-Docker. I tried the following:
In conclusion I think the Docker-to-Docker setup may not be very compatible with Codefresh since they don't seem to expose the Docker daemon without some kind of customization of the runtime environment. |
a0c6e5d
to
2257367
Compare
Thanks @qbiqing for documenting why the docker-in-docker approach failed 👍 |
b444da3
to
9af56f4
Compare
9af56f4
to
9dd4251
Compare
Wrt to running docker-in-docker in CI, Codefresh support has replied the thread, so I think I will continue experimenting in another PR. |
dcd31a0
to
df2557a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
Updated note on using DinD for integration test: https://community.codefresh.io/t/mounting-docker-socket-in-composition-step/615/2 Short answer: not possible with SaaS codefresh |
so each poll does not count as an image pull. This is needed as we got warning from
docker support of exceeding docker rate limits.