Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example publish to PS Gallery - Fixes #187 #188

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Mar 29, 2019

Pull Request (PR) description

This PR fixes the example publish to PS Gallery by adding the missing environment variable to AppVeyor.yml. Also corrected a minor layout issue in the Changelog.md.

This Pull Request (PR) fixes the following issues

#187

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me? Should be a small one.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Mar 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #188 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #188   +/-   ##
==================================
  Coverage   85%    85%           
==================================
  Files        8      8           
  Lines      853    853           
  Branches     1      1           
==================================
  Hits       732    732           
  Misses     120    120           
  Partials     1      1

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 3846b06 into dsccommunity:dev Mar 30, 2019
@PlagueHO PlagueHO deleted the Issue-187 branch March 30, 2019 19:03
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants