Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in to Localization String tests and Merge Common Modules - Fixes #195 #200

Merged
merged 5 commits into from
May 25, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented May 20, 2019

Pull Request (PR) description

This PR opts in to Localization tests and fixes string mismatches. It also moves the ResourceHelper module functions into the Common module and uses the standard functions and tests from the DSCResource.Template.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - sorry to be a pain, but would you review this one for me when you have a moment?


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #200 into dev will increase coverage by 2%.
The diff coverage is 95%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #200   +/-   ##
==================================
+ Coverage   85%    88%   +2%     
==================================
  Files        8      7    -1     
  Lines      864    943   +79     
  Branches     1      1           
==================================
+ Hits       743    831   +88     
+ Misses     120    111    -9     
  Partials     1      1

@PlagueHO
Copy link
Member Author

@johlju - would you mind reviewing this one when you get a moment? Thank you as always 😁

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Looks perfect to me. 😄

Reviewed 16 of 16 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO
Copy link
Member Author

Thank you so much @johlju !

@PlagueHO PlagueHO merged commit e267cbe into dsccommunity:dev May 25, 2019
@PlagueHO PlagueHO deleted the Issue-195 branch May 25, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt-In to Common Tests - Validating Localization
3 participants