Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ModuleBuilder change - Fixes #230 #232

Merged
merged 5 commits into from
May 17, 2020
Merged

Fix ModuleBuilder change - Fixes #230 #232

merged 5 commits into from
May 17, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented May 16, 2020 •
edited
Loading

Pull Request (PR) description

  • Fixed build failures caused by changes in ModuleBuilder module v1.7.0
    by changing CopyDirectories to CopyPaths - Fixes Issue #230.
  • Updated to use the common module DscResource.Common - Fixes Issue #229.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me please when you have time?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label May 16, 2020
johlju
johlju approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 593f2c9 into dsccommunity:master May 17, 2020
@PlagueHO PlagueHO deleted the Issue-230 branch May 17, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Build.YML to Support ModuleBuilder 1.7.0 Convert Module to use DSCResource.Common
2 participants
@PlagueHO @johlju