Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Pester 4.10.1 - Fixes #233 #234

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Pin Pester 4.10.1 - Fixes #233 #234

merged 2 commits into from
Jun 15, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jun 15, 2020 •
edited by johlju
Loading

Pull Request (PR) description

  • Pin Pester module to 4.10.1 because Pester 5.0 is missing code
    coverage - Fixes Issue #233.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - could you review this one when you have time?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jun 15, 2020
johlju
johlju approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

johlju
johlju approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit f788783 into dsccommunity:master Jun 15, 2020
@PlagueHO PlagueHO deleted the Issue-233 branch June 15, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Build Failures due to Pester 5.x
2 participants
@PlagueHO @johlju