-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerRole: Added localization and integration tests #996
SqlServerRole: Added localization and integration tests #996
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #996 +/- ##
====================================
+ Coverage 97% 97% +<1%
====================================
Files 32 32
Lines 3904 3914 +10
====================================
+ Hits 3817 3827 +10
Misses 87 87 |
- Added localization ([issue dsccommunity#621](dsccommunity#621)). - Added an outline of integration tests.
fb2057f
to
e6432d3
Compare
Reviewed 10 of 10 files at r1. DSCResources/MSFT_SqlServerRole/MSFT_SqlServerRole.psm1, line 133 at r1 (raw file):
Should be $memberToExclude DSCResources/MSFT_SqlServerRole/en-US/MSFT_SqlServerRole.strings.psd1, line 1 at r1 (raw file):
Should be SqlServerRole Tests/Integration/MSFT_SqlServerRole.config.ps1, line 123 at r1 (raw file):
Suggest we remove row 3 and 4 in the comment. Comments from Reviewable |
Reviewed 1 of 3 files at r2. DSCResources/MSFT_SqlServerRole/MSFT_SqlServerRole.psm1, line 133 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_SqlServerRole/en-US/MSFT_SqlServerRole.strings.psd1, line 1 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 3 files at r2. Comments from Reviewable |
Review status: Comments from Reviewable |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues:
Fixes #621
Fixes #756
Task list:
This change is