Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebsite: multiple HTTPS bindings with different thumbprints (#332) #437

Merged
merged 1 commit into from
Sep 6, 2019
Merged

xWebsite: multiple HTTPS bindings with different thumbprints (#332) #437

merged 1 commit into from
Sep 6, 2019

Conversation

mcbobke
Copy link
Contributor

@mcbobke mcbobke commented Sep 4, 2019 •
edited
Loading

Pull Request (PR) description

Fix multiple HTTPS bindings on one xWebsite receiving the first binding's certificate, added unit regression test and changelog entry. Credit to @konste for the original fix #347

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@mbobke
Fix multiple HTTPS bindings on one xWebsite receiving the first
a3f369e 
binding's certificate, added unit regression test
@codecov-io
Copy link

Codecov Report

Merging #437 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #437      +/-   ##
==========================================
+ Coverage   90.77%   90.77%   +<.01%     
==========================================
  Files          17       17              
  Lines        2438     2439       +1     
==========================================
+ Hits         2213     2214       +1     
  Misses        225      225
Impacted Files Coverage Δ
DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1 97.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70aad44...a3f369e. Read the comment docs.

@mcbobke mcbobke mentioned this pull request Sep 4, 2019
Closed
@mcbobke
Copy link
Contributor Author

mcbobke commented Sep 4, 2019

@johlju please let me know if there are more tests to be written or if you have any other guidance.

@johlju
Copy link
Member

johlju commented Sep 5, 2019

I will review this as soon as I can. But had to work late a the day job today. I will try to get to it tomorrow or Saturday.

@mcbobke
Copy link
Contributor Author

mcbobke commented Sep 5, 2019

Thank you for the update and for taking the time to review it, I understand being busy!

johlju
johlju reviewed Sep 6, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
Copy link
Member

johlju commented Sep 6, 2019 •
edited
Loading

No problem, happy to get this resolved. 🙂

@mcbobke (or @gaelcolas) Could you please add Closing #347 to the PR description, then that PR will close also when this is merged.

@gaelcolas can you please merge this one? (poking Gael offline too)

@mcbobke
Copy link
Contributor Author

mcbobke commented Sep 6, 2019

Added Closes #347.

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 6, 2019
@johlju
Copy link
Member

johlju commented Sep 6, 2019

@mcbobke got myself permission to this repo so I can merge myself now.

@johlju johlju merged commit a7139f1 into dsccommunity:dev Sep 6, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 6, 2019
@mcbobke
Copy link
Contributor Author

mcbobke commented Sep 6, 2019

Awesome! Thank you!

@regedit32 regedit32 mentioned this pull request Oct 2, 2019
Closed
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
@mcbobke
xWebsite: Fix multiple HTTPS bindings on one xWebsite receiving the f…
1484fbc 
…irst (dsccommunity#437)

- Fix multiple HTTPS bindings on one xWebsite receiving the first binding's certificate [dsccommunity#332](dsccommunity#332)
  - Added unit regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG in SSL certificates assignment to bindings
4 participants
@mcbobke @codecov-io @johlju @mbobke