Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setting up the project #2

Closed
wants to merge 11 commits into from
Closed

chore: setting up the project #2

wants to merge 11 commits into from

Conversation

Srish-ty
Copy link
Member

@Srish-ty Srish-ty commented Jun 3, 2024

Following changes are added by this pull_request:

  • Set up react project with pnpm as package manager
  • added prettier and eslint scripts for formatting and workflows

@Srish-ty
Copy link
Member Author

Srish-ty commented Jun 3, 2024

@Shurtu-gal please review

Shurtu-gal
Shurtu-gal reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe we could use vite or sth else to setup the react project. For reference:- reactjs/react.dev#5487 (comment)

src/components/styles/Navbar.styles.jsx Outdated Show resolved Hide resolved
settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be in .vscode. And could you explain the settings purposes.

Copy link
Member Author

@Srish-ty Srish-ty Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts (pnpm lint) for eslint were giving error : no file found with \"src/**/*.{js,jsx}\" format without the settings.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this should be in .vscode if I am not wrong.

README.md Show resolved Hide resolved
@Srish-ty Srish-ty requested a review from Shurtu-gal June 4, 2024 11:30
Shurtu-gal
Shurtu-gal requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still left #2 (review)

README.md Show resolved Hide resolved
babel.config.json
@@ -0,0 +1,8 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still required?

settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this should be in .vscode if I am not wrong.

@Srish-ty
Copy link
Member Author

Srish-ty commented Jun 4, 2024

Also maybe we could use vite or sth else to setup the react project. For reference:- reactjs/react.dev#5487 (comment)

set new project up using vite.
pr link:

@Shurtu-gal Shurtu-gal closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shurtu-gal Shurtu-gal Shurtu-gal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Srish-ty @Shurtu-gal