Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting capability, and basic XSS security in popup.js #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Voting capability, and basic XSS security in popup.js #4

wants to merge 9 commits into from

Conversation

ClimbsRocks
Copy link

I just realized that the branch I cloned from did not have a gitgnore file. Feel free to reject this commit if you want to keep bower_components out of this chain.

Also note that I am unsure how to test popup.js. I used this exact same escapeHtml in the past, so I would expect it to work. However, I'm not sure how to compile into an extension I can use, so I haven't been able to test it yet.

omarduarte and others added 9 commits January 8, 2015 21:24
@dsernst
Copy link
Owner

dsernst commented Jan 15, 2015

Awesome!!! Can you push a commit to this branch with bower_components
.gitignored?

On Sunday, January 11, 2015, Preston Parry [email protected] wrote:

I just realized that the branch I cloned from did not have a gitgnore
file. Feel free to reject this commit if you want to keep bower_components
out of this chain.

Also note that I am unsure how to test popup.js. I used this exact same
escapeHtml in the past, so I would expect it to work. However, I'm not sure
how to compile into an extension I can use, so I haven't been able to test

it yet.

You can merge this Pull Request by running

git pull https://github.com/ClimbsRocks/lfx-post master

Or view, comment on, or merge it at:

#4
Commit Summary

  • Added parser helper functions
  • Working
  • Fixed dates and timestamps in index
  • added parseID of each object to each tablerow, so we can update that
    object's vote specifically
  • added a voting button to each row
  • refactored code to use promises so we can start event listeners
    after buttons have been appended to the DOM. installed bluebird
  • added ability to vote- click a button to vote, send vote to db,
    fetch all data from db again.
  • adding escapeHtml function (xss security solution from mustachejs).
    NOTE: escapeHtml IS NOT IMPLEMENTED YET, just downloaded and available
  • escapedHtml user input, first line of defense against XSS attacks

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#4.

David Ernst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClimbsRocks @dsernst @omarduarte