Browser #364
Merged
Browser #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this means it will work in StackBlitz and similar? Nice! 🎉 |
|
I think not, yet. we still need to distribute main.js file (for browsers) and declare that one in "browser" property - I don't think stackbliz will run bundlers theirself - I think they just use cdns like https://unpkg.com/ . The nice thing is if we generate that in npm pubish those cdns will expose the fie automatically. will try to test this in my fork when have time |
|
Thanks! 😄 |
dsherret
pushed a commit
that referenced
this pull request
May 14, 2019
* browser support * package.json browser property to ignore dependencies in browser * package.json browser property * dont ignore path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marking dependencies to be ignored by browser bundlers, references: https://github.com/Microsoft/TypeScript/blob/60986adee5a96579a258a2dd896f4bd3d2da6c98/package.json#L109