Simplifying Vatz Proto #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xellos00
requested review from
gnongs,
heejin-github,
hqueue,
kim201212,
meetrick and
rootwarp
rootwarp
reviewed
Mar 16, 2022
| } | ||
| package vatz.manager; | ||
| option go_package = "github.com/xellos00/dk-yuba-proto/proto/vatz/manager/v1"; | ||
|
|
There was a problem hiding this comment.
As I understand, Manager service will be dummy for now. It is for future work, am I right?
There was a problem hiding this comment.
I thought it was just dummy pkg name for this time but,
There are same name in request or response in two protos within APIs as below, and therefore I want to keep it this way by using pkg name.
@rootwarp @hqueue
Do you prefer to remove pkg and change all request and response name?
btw, we need to update protos anyway once we settle our own rules for protos to organize in handy.
Let me know if there's further discussion needed regard above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying Vatz-Proto