Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to remove "interface" types #125

Closed
4 of 7 tasks
rootwarp opened this issue May 18, 2022 · 5 comments · Fixed by #182
Closed
4 of 7 tasks

Refactoring to remove "interface" types #125

rootwarp opened this issue May 18, 2022 · 5 comments · Fixed by #182
Labels
area:team Anything related to team :) good_first_issue Good for newcomers type:discussion Issue that has to go over discussion. type:feature-request If there anyone has to raise a hand to request new feature. Vatz Project Name

Comments

@rootwarp
Copy link
Member

rootwarp commented May 18, 2022

Checklist

  • New Feature for the SVC/Plugin
  • New Feature for CI/CD
  • Enhancement on Vatz
  • Others(etc. e.g, documentation,...)

Please describe, what it's about or related Problem with

A clear description of what feature need to be developed or enhanced in Vatz

interface type is using too much all of the code base.
But it could be serious problem in near future because,

  • This means source code is not self-documented. Developer can't understand code easily if variables are defined as interface type
  • interface type can be broken in runtime. We should test really hard by checking every possible values.
  • And that means development pace will be slow down.

Describe the output that you are expecting for above

A clear and concise description of what you expect to happen.

Avoid to use interface type if possible.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

This refactoring task will be huge job and also will be affected to other tasks that are on going.
So I suggest do refactoring task by module one by one.

Additional context

Add any other context or screenshots about the feature request here.


Child issues.

@rootwarp rootwarp added Vatz Project Name type:feature-request If there anyone has to raise a hand to request new feature. labels May 18, 2022
@rootwarp
Copy link
Member Author

@xellos00 What do you think of my suggestion?

@xellos00
Copy link
Member

xellos00 commented May 19, 2022

@rootwarp
I understand your concern, Can we prioritize all issue in order first unless you want to proceed this issue in this Sprint.

@rootwarp
Copy link
Member Author

@rootwarp I understand your concern, Can we prioritize all issue in order unless you want to proceed this issue in this Sprint.

Yup.

@xellos00 xellos00 added area:team Anything related to team :) type:discussion Issue that has to go over discussion. labels May 25, 2022
@xellos00
Copy link
Member

@xellos00
Task

  • Remove any Type in interface.
  • Maximize Unit test.

@xellos00
Copy link
Member

I will close this issue as all sub-issue has finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:team Anything related to team :) good_first_issue Good for newcomers type:discussion Issue that has to go over discussion. type:feature-request If there anyone has to raise a hand to request new feature. Vatz Project Name
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants