Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developments for VATZ CLI Commands #178

Closed
7 of 11 tasks
xellos00 opened this issue Jul 12, 2022 · 8 comments
Closed
7 of 11 tasks

Developments for VATZ CLI Commands #178

xellos00 opened this issue Jul 12, 2022 · 8 comments
Assignees
Labels
area:svc Anything related to Vatz Service. good_first_issue Good for newcomers type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name

Comments

@xellos00
Copy link
Member

xellos00 commented Jul 12, 2022


Checklist


Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. such as Ex. I'm always frustrated

Describe the solution you'd like| Ex

A clear and concise description of what you want to happen

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you have considered.


Child Issue(List up)

@xellos00 xellos00 added Vatz Project Name type:feature-development Any development regarding Vatz service/plugin, etc. labels Jul 12, 2022
@xellos00 xellos00 assigned xellos00 and rootwarp and unassigned xellos00 Jul 12, 2022
@xellos00 xellos00 added the area:svc Anything related to Vatz Service. label Jul 12, 2022
@xellos00 xellos00 added this to the Sprint 13 ( ~ 2022-07-20) milestone Jul 12, 2022
@rootwarp
Copy link
Member

Hold until #125 issue is done.

@rootwarp
Copy link
Member

@xellos00 I gonna start this issue from very simple plan.
it could be better to start this in simple and discuss usability and additional ideas with other members after this done.

Here are three command that I expects.

  • vatz start --config default.yaml: will start vatz with chosen config.
  • vatz init --home ~/vatz: will create default config file on chosen location
  • vatz plugin list: will list configured plugins and its status.

@xellos00
Copy link
Member Author

xellos00 commented Jul 22, 2022

@xellos00 I gonna start this issue from very simple plan. it could be better to start this in simple and discuss usability and additional ideas with other members after this done.

Here are three command that I expects.

  • vatz start --config default.yaml: will start vatz with chosen config.
  • vatz init --home ~/vatz: will create default config file on chosen location
  • vatz plugin list: will list configured plugins and its status.

@rootwarp
Can you add following commands as well for basic

  • vatz start --log ~/vatz/logs (just redirection)
  • vatz stop
  • vatz help

I'd like to set CLI commands format such as

  • Basic commands
    • vatz - {action}
      e.g.) vatz start, vatz stop vatz help vatz init vatz version
  • Service related
    • vatz - {service} - {action}
      e.g) vatz monitoring setAddr, vatz monitoring upstatus

What do you think?

@rootwarp
Copy link
Member

@xellos00 I gonna start this issue from very simple plan. it could be better to start this in simple and discuss usability and additional ideas with other members after this done.
Here are three command that I expects.

  • vatz start --config default.yaml: will start vatz with chosen config.
  • vatz init --home ~/vatz: will create default config file on chosen location
  • vatz plugin list: will list configured plugins and its status.

@rootwarp Can you add following commands as well for basic

  • vatz start --log ~/vatz/logs (just redirection)
  • vatz stop
  • vatz help

I'd like to set CLI commands format such as

  • Basic commands

    • vatz - {action}
      e.g.) vatz start, vatz stop vatz help vatz init vatz version
  • Service related

    • vatz - {service} - {action}
      e.g) vatz monitoring setAddr, vatz monitoring upstatus

What do you think?

@xellos00 I'll list up those in this issue and I think it could be better implement sub command one by one on different issue. is it ok?

@rootwarp rootwarp added the good_first_issue Good for newcomers label Jul 22, 2022
@rootwarp
Copy link
Member

@xellos00 Regarding to stop command, I think we need to define more precisely both start and stop.

I thought start command will works totally same to usual blockchain node (e.g cosmos-hub).
So if we start node with start command, vatz will work on foreground.
That means we don't need to have stop command because we can just do ctrl-z for stopping vatz.

But your plan seems different from that I mentioned and I think that it is also reasonable and usual approach.

Because your plan could change many parts of structure, we need to discuss about it before doing implementation from here.
So I suggest that implementing only start command without changing behavior and discuss about your plan from the other issue. How do you think about this?

@xellos00
Copy link
Member Author

xellos00 commented Jul 22, 2022

@xellos00 Regarding to stop command, I think we need to define more precisely both start and stop.

I thought start command will works totally same to usual blockchain node (e.g cosmos-hub). So if we start node with start command, vatz will work on foreground. That means we don't need to have stop command because we can just do ctrl-z for stopping vatz.

But your plan seems different from that I mentioned and I think that it is also reasonable and usual approach.

Because your plan could change many parts of structure, we need to discuss about it before doing implementation from here. So I suggest that implementing only start command without changing behavior and discuss about your plan from the other issue. How do you think about this?

@rootwarp
Agree, seems basic command behaviors might different what each of us think of, and need to approaches start & stop more precisely due to its details.
Let's stick around with plan as you mention on first thread ,that doesn't have other option behaviors, and then I will list up on excel file with exact behaviors + options in another issue under parents.

@rootwarp
Copy link
Member

@xellos00 vatz help command does not necessary because cobra package already provides similar one.
what do you thing?

@xellos00
Copy link
Member Author

xellos00 commented Feb 1, 2024

@xellos00 vatz help command does not necessary because cobra package already provides similar one. what do you thing?

I agree!!. Would you close this issue if you don't mind?

@rootwarp rootwarp closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. good_first_issue Good for newcomers type:feature-development Any development regarding Vatz service/plugin, etc. Vatz Project Name
Projects
None yet
Development

No branches or pull requests

2 participants