Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of NewHealthChecker #231

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix return type of NewHealthChecker #231

merged 1 commit into from
Aug 16, 2022

Conversation

rootwarp
Copy link
Member

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Factory function should return interface type.

Related: # (issue)

closes #230

Summary

3. Comments

Please, leave a comments if there's further action that requires.

@rootwarp rootwarp requested a review from a team August 15, 2022 12:26
@rootwarp rootwarp self-assigned this Aug 15, 2022
@rootwarp rootwarp added Vatz Project Name area:svc Anything related to Vatz Service. labels Aug 15, 2022
@rootwarp rootwarp added this to the Sprint 15 ( ~ 2022-08-17) milestone Aug 15, 2022
heejin-github
heejin-github approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@heejin-github heejin-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootwarp rootwarp mentioned this pull request Aug 16, 2022
Merged
4 tasks
kim201212
kim201212 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@kim201212 kim201212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@rootwarp rootwarp added the type:enhancement Any enhancement for feature or anything label Aug 16, 2022
@xellos00 xellos00 merged commit 60572f7 into dsrvlabs:main Aug 16, 2022
@xellos00 xellos00 deleted the issue#230 branch August 16, 2022 05:01
@xellos00 xellos00 removed this from the Sprint 15 ( ~ 2022-08-17) milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heejin-github heejin-github heejin-github approved these changes

@kim201212 kim201212 kim201212 approved these changes

@xellos00 xellos00 xellos00 approved these changes

Assignees

@rootwarp rootwarp

Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix NewHealthChecker function's return
4 participants
@rootwarp @xellos00 @kim201212 @heejin-github