Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Enhancements include reminder #255

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Notification Enhancements include reminder #255

merged 5 commits into from
Oct 7, 2022

Conversation

xellos00
Copy link
Member

@xellos00 xellos00 commented Oct 4, 2022

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Related: # (issue)
close #174
close #246

Summary

  1. Send Notification when flags(State + Severity) have changed from previous results.
  2. Reminder to recover is stop when state: SUCCESS, Severity: INFO
  3. When Plugin is Down filter from health check
    Health Check only Sent Single Message that Plugin is Down.
    Will be covered on other issue for health Check Reminder.
State Severity Send Notification (Y/N) Reminder (Y/N)
SUCCESS WARNING Y Y
SUCCESS CRITICAL Y Y
SUCCESS INFO Y N
FAILURE * Y Y
ANY OTHER * N


3. Comments

Please, leave a comments if there's further action that requires.

@xellos00 xellos00 requested review from gnongs, rootwarp, heejin-github, hqueue, kim201212, meetrick and skonhwang and removed request for gnongs and rootwarp October 4, 2022 07:03
@xellos00 xellos00 self-assigned this Oct 4, 2022
@xellos00 xellos00 added Vatz Project Name area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything labels Oct 4, 2022
Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rootwarp@Mindhack2021 ~/g/d/vatz ISSUE-174-revised > make coverage
echo "Test Coverage script will be here"
Test Coverage script will be here
ok      github.com/dsrvlabs/vatz        3.425s  coverage: 11.0% of statements
ok      github.com/dsrvlabs/vatz/manager/api    1.667s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 1.603s  coverage: 95.0% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     2.007s  coverage: 8.9% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       2.427s  coverage: 68.2% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    2.676s  coverage: 45.0% of statements
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/rpc    4.016s  coverage: 65.5% of statements

"text": text,
"chat_id": t.chatID,
"text": sendingText,
"parse_mode": "markdown",
Copy link
Member

@gnongs gnongs Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xellos00
I think parse_made is not work.

2022-10-07T18:00:23+09:00 ERR dispatcher CH: Telegram-Invalid telegram token. module=dispatcher

When I remove this valuable, It is work.
image

below log is return body.

{"ok":false,"error_code":400,"description":"Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 96"}

Copy link
Member Author

@xellos00 xellos00 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnongs
I cloned again with main branch after merge and I confirmed it works preperly.
Can you compare your telegram message to below, your message is not in formatted as markdown.

image

image

Can you raise another issue with your case above if you still have same trouble with new cloning or after pull latest commits
just Keep in mind that when you share your configs on issue, you need to blur all your secret to prevent other trouble.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@heejin-github heejin-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send Discord alert as we expected. 👍

  1. plugin down
  • send CRITICAL when it down
  • send only once not repeated.
  • send INFO when it recover

image

  1. Send Notification from plugin
  • send alert as determined severity by plugin
  • send alert repeated by reminder schedule
  • send INFO when it recovered
  • reminder is stop when its state : SUCCESS, severity : INFO

repeated by reminder schedule (every minute in this case)

image

send alert WARNING -> CRITICAL -> WARNING well.
send INFO when it recovered, and it didn't repeated to send INFO level notification.

image

@xellos00 xellos00 merged commit a2363f5 into dsrvlabs:main Oct 7, 2022
@xellos00 xellos00 deleted the ISSUE-174-revised branch October 7, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
4 participants