-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification Enhancements include reminder #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rootwarp@Mindhack2021 ~/g/d/vatz ISSUE-174-revised > make coverage
echo "Test Coverage script will be here"
Test Coverage script will be here
ok github.com/dsrvlabs/vatz 3.425s coverage: 11.0% of statements
ok github.com/dsrvlabs/vatz/manager/api 1.667s coverage: 0.0% of statements [no tests to run]
ok github.com/dsrvlabs/vatz/manager/config 1.603s coverage: 95.0% of statements
ok github.com/dsrvlabs/vatz/manager/dispatcher 2.007s coverage: 8.9% of statements
ok github.com/dsrvlabs/vatz/manager/executor 2.427s coverage: 68.2% of statements
ok github.com/dsrvlabs/vatz/manager/healthcheck 2.676s coverage: 45.0% of statements
? github.com/dsrvlabs/vatz/manager/types [no test files]
? github.com/dsrvlabs/vatz/mocks [no test files]
ok github.com/dsrvlabs/vatz/rpc 4.016s coverage: 65.5% of statements
"text": text, | ||
"chat_id": t.chatID, | ||
"text": sendingText, | ||
"parse_mode": "markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xellos00
I think parse_made
is not work.
2022-10-07T18:00:23+09:00 ERR dispatcher CH: Telegram-Invalid telegram token. module=dispatcher
When I remove this valuable, It is work.
below log is return body
.
{"ok":false,"error_code":400,"description":"Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 96"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnongs
I cloned again with main branch after merge and I confirmed it works preperly.
Can you compare your telegram message to below, your message is not in formatted as markdown.
Can you raise another issue with your case above if you still have same trouble with new cloning or after pull latest commits
just Keep in mind that when you share your configs on issue, you need to blur all your secret to prevent other trouble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xellos00 I have noted the issue below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send Discord alert as we expected. 👍
- plugin down
- send CRITICAL when it down
- send only once not repeated.
- send INFO when it recover
- Send Notification from plugin
- send alert as determined severity by plugin
- send alert repeated by reminder schedule
- send INFO when it recovered
- reminder is stop when its state : SUCCESS, severity : INFO
repeated by reminder schedule (every minute in this case)
send alert WARNING -> CRITICAL -> WARNING well.
send INFO when it recovered, and it didn't repeated to send INFO level notification.
1. Type of change
Please delete options that are not relevant.
2. Summary
Related: # (issue)
close #174
close #246
Summary
Health Check only Sent Single Message that Plugin is Down.
Will be covered on other issue for health Check Reminder.
3. Comments