Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Dispatcher PagerDuty #296

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Add new Dispatcher PagerDuty #296

merged 3 commits into from
Nov 8, 2022

Conversation

xellos00
Copy link
Member

@xellos00 xellos00 commented Oct 29, 2022

  • Add a new dispatcher PagerDuty
  • Update Configs include 'pagerDuty' Conf

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Related: # (issue)
close: #261

Summary

Add pagerduty as new dispatcher so, we can get a call through phone by pagerduty.


3. Comments

Please, leave a comments if there's further action that requires.

Coverage

 dongyookang DK 🐵   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-261 ±✚
 make coverage
fatal: No names found, cannot describe anything.
echo "Test Coverage script will be here"
Test Coverage script will be here
?       github.com/dsrvlabs/vatz        [no test files]
ok      github.com/dsrvlabs/vatz/cmd    0.936s  coverage: 9.5% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.285s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.303s  coverage: 92.0% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.693s  coverage: 7.1% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       0.567s  coverage: 68.2% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    0.329s  coverage: 45.0% of statements
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/rpc    1.827s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.175s  coverage: 100.0% of statements

vatz Start

 dongyookang DK 🐵   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-261
 make clean   
fatal: No names found, cannot describe anything.
go clean
 dongyookang DK 🐵   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-261
 make build
fatal: No names found, cannot describe anything.
go build -ldflags="-X 'main.Version=ISSUE-261' -X 'main.Commit=c4439f9'" -v
github.com/dsrvlabs/vatz/manager/executor
github.com/dsrvlabs/vatz/manager/healthcheck
github.com/dsrvlabs/vatz/cmd
github.com/dsrvlabs/vatz
 dongyookang DK 🐵   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-261
 ./vatz init
2022-10-28T23:56:18-05:00 INF init module=main
2022-10-28T23:56:18-05:00 INF create file default.yaml module=main
 dongyookang DK 🐵   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-261
 ./vatz start                       
2022-10-28T23:56:21-05:00 INF start module=main
2022-10-28T23:56:21-05:00 INF load config default.yaml module=main
2022-10-28T23:56:21-05:00 INF logfile  module=main
2022-10-28T23:56:21-05:00 INF Load Config default.yaml module=config
2022-10-28T23:56:21-05:00 INF Initialize Servers: VATZ Manager module=main
2022-10-28T23:56:21-05:00 INF VATZ Listening Port: :9090 module=main
2022-10-28T23:56:21-05:00 INF VATZ Manager Started module=main
2022-10-28T23:56:21-05:00 INF start rpc server module=rpc
2022-10-28T23:56:21-05:00 INF start gRPC gateway server 127.0.0.1:19091 module=rpc
2022-10-28T23:56:21-05:00 INF start gRPC server 127.0.0.1:19090 module=rpc
^C

- Update Configs include 'pagerDuty' Conf
@xellos00 xellos00 changed the title New Dispatcher PagerDuty Add new Dispatcher PagerDuty Oct 29, 2022
@xellos00 xellos00 self-assigned this Oct 29, 2022
@xellos00 xellos00 added Vatz Project Name area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything labels Oct 29, 2022
Copy link
Member

@meetrick meetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manager/dispatcher/discord.go Outdated Show resolved Hide resolved
manager/dispatcher/pagerduty.go Outdated Show resolved Hide resolved
manager/dispatcher/pagerduty.go Outdated Show resolved Hide resolved
manager/dispatcher/telegram.go Outdated Show resolved Hide resolved
@xellos00
Copy link
Member Author

xellos00 commented Nov 8, 2022

with updated code

image

Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xellos00 xellos00 merged commit c83b7cc into dsrvlabs:main Nov 8, 2022
@xellos00 xellos00 deleted the ISSUE-261 branch November 8, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new dispatcher type : PagerDuty
3 participants