List command of plugin #335

rootwarp · 2022-12-09T10:13:43Z

1. Type of change

Please delete options that are not relevant.

New feature
Enhancement
Bug/fix (non-breaking change which fixes an issue)
others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Related: # (issue)

close #320

Summary

List command of plugin that are installed on local machine.

~$ ./vatz plugin install https://github.com/dsrvlabs/vatz-plugin-cosmoshub/plugins/node_active_status cosmos-status

~$ vatz plugin list

3. Comments

Please, leave a comments if there's further action that requires.

rootwarp · 2022-12-09T10:14:38Z

@xellos00 Please take look at this before merging #317.
I'll rebase this after #317 merged.

xellos00 · 2022-12-10T03:38:33Z

@xellos00 Please take look at this before merging #317. I'll rebase this after #317 merged.

so review this first, before merge #317 right?

rootwarp · 2022-12-10T05:36:51Z

@xellos00 Please take look at this before merging #317. I'll rebase this after #317 merged.

so review this first, before merge #317 right?

@xellos00
Yes. Due to the previous PR being delayed to merging, I implemented this feature based on previous PR in advance. I just hope that you can inspect this code in detail and get more feedback for new feature.

xellos00 · 2022-12-12T01:15:22Z

@xellos00 Please take look at this before merging #317. I'll rebase this after #317 merged.

so review this first, before merge #317 right?

@xellos00 Yes. Due to the previous PR being delayed to merging, I implemented this feature based on previous PR in advance. I just hope that you can inspect this code in detail and get more feedback for new feature.

got it!!

xellos00 · 2022-12-12T19:18:14Z

Okay for Coverage

 dongyookang DK ⚡️   ~/ffplay/GolandProjects/dsrvlabs/vatz   list
 make coverage
fatal: No names found, cannot describe anything.
echo "Test Coverage script will be here"
Test Coverage script will be here
# github.com/dsrvlabs/vatz/manager/plugin.test
ld: warning: -no_pie is deprecated when targeting new OS versions
?   	github.com/dsrvlabs/vatz	[no test files]
# github.com/dsrvlabs/vatz/cmd.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ok  	github.com/dsrvlabs/vatz/cmd	2.711s	coverage: 17.1% of statements
ok  	github.com/dsrvlabs/vatz/manager/api	0.378s	coverage: 0.0% of statements [no tests to run]
ok  	github.com/dsrvlabs/vatz/manager/config	0.444s	coverage: 91.2% of statements
ok  	github.com/dsrvlabs/vatz/manager/dispatcher	0.464s	coverage: 7.3% of statements
ok  	github.com/dsrvlabs/vatz/manager/executor	0.557s	coverage: 68.9% of statements
ok  	github.com/dsrvlabs/vatz/manager/healthcheck	0.672s	coverage: 46.3% of statements
ok  	github.com/dsrvlabs/vatz/manager/plugin	2.877s	coverage: 68.0% of statements
?   	github.com/dsrvlabs/vatz/manager/types	[no test files]
?   	github.com/dsrvlabs/vatz/mocks	[no test files]
ok  	github.com/dsrvlabs/vatz/rpc	1.792s	coverage: 67.2% of statements
ok  	github.com/dsrvlabs/vatz/utils	0.163s	coverage: 50.0% of statements
 dongyookang DK ⚡️   ~/ffplay/GolandProjects/dsrvlabs/vatz   list

Plugin List test

 ./vatz plugin list
2022-12-12T13:17:12-06:00 INF List plugins module=plugin
2022-12-12T13:17:12-06:00 INF List module=plugin
2022-12-12T13:17:12-06:00 INF newReader /Users/dongyookang/.vatz/vatz.db module=db
2022-12-12T13:17:12-06:00 INF Create DB Instance module=db
2022-12-12T13:17:12-06:00 INF List Plugin module=db
+---------------+---------------------+------------------------------------------------------------------------------+---------+
| NAME          | INSTALL DATA        | REPOSITORY                                                                   | VERSION |
+---------------+---------------------+------------------------------------------------------------------------------+---------+
| cosmos-status | 2022-12-01 21:52:44 | https://github.com/dsrvlabs/vatz-plugin-cosmoshub/plugins/node_active_status | latest  |
| cpu-monitor   | 2022-12-01 22:11:05 | https://github.com/dsrvlabs/vatz-plugin-sysutil/plugins/cpu_monitor          | latest  |
+---------------+---------------------+------------------------------------------------------------------------------+---------+

@rootwarp
Can you Check up followings?

Column name typo
- INSTALL DATA => INSTALLATION DATE
Column Order
- Name, REPOSITORY, VERSION, INSTALLATION DATE
Get rid of following lines?
Or is this intentionally printed out?

 ./vatz plugin list
2022-12-12T13:17:12-06:00 INF List plugins module=plugin
2022-12-12T13:17:12-06:00 INF List module=plugin
2022-12-12T13:17:12-06:00 INF newReader /Users/dongyookang/.vatz/vatz.db module=db
2022-12-12T13:17:12-06:00 INF Create DB Instance module=db
2022-12-12T13:17:12-06:00 INF List Plugin module=db

rootwarp · 2022-12-13T03:37:33Z

@xellos00 Responses.

@rootwarp Can you Check up followings?

Column name typo

INSTALL DATA => INSTALLATION DATE

I'll change it.

Column Order

Name, REPOSITORY, VERSION, INSTALLATION DATE

Also I'll change it.

Get rid of following lines?
Or is this intentionally printed out?

 ./vatz plugin list
2022-12-12T13:17:12-06:00 INF List plugins module=plugin
2022-12-12T13:17:12-06:00 INF List module=plugin
2022-12-12T13:17:12-06:00 INF newReader /Users/dongyookang/.vatz/vatz.db module=db
2022-12-12T13:17:12-06:00 INF Create DB Instance module=db
2022-12-12T13:17:12-06:00 INF List Plugin module=db

Regarding this, I thought few hours before implementing this and I think we need to discuss and decide policies for logs.

As you can see, this problem is caused because the output channels for the log and the result are identical.

We may remove the logging code or disable log outputs for some command lines
and these could be the item that we have to discuss.
Before we discuss this, I think it could be better to keep log messages that will help implementation.

xellos00 · 2022-12-13T10:28:56Z

@xellos00 Responses.

@rootwarp Can you Check up followings?

Column name typo

INSTALL DATA => INSTALLATION DATE

I'll change it.

Column Order

Name, REPOSITORY, VERSION, INSTALLATION DATE

Also I'll change it.
Get rid of following lines?
Or is this intentionally printed out?
 ./vatz plugin list
2022-12-12T13:17:12-06:00 INF List plugins module=plugin
2022-12-12T13:17:12-06:00 INF List module=plugin
2022-12-12T13:17:12-06:00 INF newReader /Users/dongyookang/.vatz/vatz.db module=db
2022-12-12T13:17:12-06:00 INF Create DB Instance module=db
2022-12-12T13:17:12-06:00 INF List Plugin module=db
Regarding this, I thought few hours before implementing this and I think we need to discuss and decide policies for logs.

As you can see, this problem is caused because the output channels for the log and the result are identical.

We may remove the logging code or disable log outputs for some command lines and these could be the item that we have to discuss. Before we discuss this, I think it could be better to keep log messages that will help implementation.

Let's separate log issue from this.
I will create another issue to discuss for this problem.

cmd/plugin.go

meetrick

I haven't tested it yet, but there seems to be no problem with the operation.
But please check typo error comment.

cmd/plugin.go

manager/plugin/db.go

heejin-github

LGTM!

rootwarp self-assigned this Dec 9, 2022

rootwarp added Vatz Project Name area:svc Anything related to Vatz Service. type:feature-development Any development regarding Vatz service/plugin, etc. labels Dec 9, 2022

rootwarp requested a review from xellos00 December 9, 2022 10:14

xellos00 mentioned this pull request Dec 13, 2022

Install and start plugin by CLI #317

Merged

4 tasks

Impl. list command of plugin

994b078

rootwarp force-pushed the list branch from eb513cb to 994b078 Compare December 16, 2022 07:17

rootwarp requested a review from a team December 16, 2022 07:46

skonhwang reviewed Dec 16, 2022

View reviewed changes

cmd/plugin.go Show resolved Hide resolved

xellos00 requested review from heejin-github and meetrick December 23, 2022 08:07

skonhwang approved these changes Dec 23, 2022

View reviewed changes

meetrick reviewed Dec 23, 2022

View reviewed changes

cmd/plugin.go Outdated Show resolved Hide resolved

manager/plugin/db.go Outdated Show resolved Hide resolved

heejin-github approved these changes Dec 23, 2022

View reviewed changes

rootwarp added 2 commits December 26, 2022 11:40

Fix typo

e6566f8

Fix typo

30f797c

xellos00 merged commit 9c72df3 into dsrvlabs:main Dec 26, 2022

rootwarp deleted the list branch January 4, 2023 06:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List command of plugin #335

List command of plugin #335

rootwarp commented Dec 9, 2022

rootwarp commented Dec 9, 2022 •

edited

Loading

xellos00 commented Dec 10, 2022

rootwarp commented Dec 10, 2022

xellos00 commented Dec 12, 2022

xellos00 commented Dec 12, 2022 •

edited

Loading

rootwarp commented Dec 13, 2022

xellos00 commented Dec 13, 2022

meetrick left a comment

heejin-github left a comment

List command of plugin #335

List command of plugin #335

Conversation

rootwarp commented Dec 9, 2022

1. Type of change

2. Summary

3. Comments

rootwarp commented Dec 9, 2022 • edited Loading

xellos00 commented Dec 10, 2022

rootwarp commented Dec 10, 2022

xellos00 commented Dec 12, 2022

xellos00 commented Dec 12, 2022 • edited Loading

Okay for Coverage

Plugin List test

rootwarp commented Dec 13, 2022

xellos00 commented Dec 13, 2022

meetrick left a comment

Choose a reason for hiding this comment

heejin-github left a comment

Choose a reason for hiding this comment

rootwarp commented Dec 9, 2022 •

edited

Loading

xellos00 commented Dec 12, 2022 •

edited

Loading