Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused version.go file #442

Merged
merged 1 commit into from
May 24, 2023
Merged

Remove unused version.go file #442

merged 1 commit into from
May 24, 2023

Conversation

kim201212
Copy link
Member

@kim201212 kim201212 commented May 23, 2023

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Related: #344

Summary

  • Remove duplicate version.go file

3. Comments

Please, leave a comments if there's further action that requires.

@kim201212 kim201212 changed the title Remove unused version file Remove unused version.go file May 23, 2023
@kim201212 kim201212 requested review from xellos00 and rootwarp May 23, 2023 08:41
@xellos00
Copy link
Member

xellos00 commented May 23, 2023

@kim201212

  • Can you put its coverage test output?
  • People wouldn't understand tis details, can you put explanation on summary?
  • Shouldn't you get rid of version_test.go file too when you delete version.go

@xellos00 xellos00 added Vatz Project Name type:enhancement Any enhancement for feature or anything labels May 23, 2023
@kim201212
Copy link
Member Author

$ make coverage 
fatal: No names found, cannot describe anything.
?       github.com/dsrvlabs/vatz        [no test files]
# github.com/dsrvlabs/vatz/manager/plugin.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# github.com/dsrvlabs/vatz/cmd.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
ok      github.com/dsrvlabs/vatz/cmd    9.378s  coverage: 19.8% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.275s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.275s  coverage: 79.4% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.854s  coverage: 7.8% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       1.429s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    1.728s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 16.702s coverage: 51.1% of statements
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  1.137s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    3.023s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.600s  coverage: 7.1% of statements

@kim201212
Copy link
Member Author

kim201212 commented May 24, 2023

@kim201212

  • Can you put its coverage test output?
  • People wouldn't understand tis details, can you put explanation on summary?
  • Shouldn't you get rid of version_test.go file too when you delete version.go
  • Remove duplicate version.go file

Copy link
Member

@meetrick meetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootwarp
Copy link
Member

rootwarp@mindhack ~/g/d/vatz go-lint > ./vatz version

   @@@@@@@@@@@@@@@         @@@@@@@@@@@@@@@@@@@
    #@@@@@@@@@@@@@@@           @@@@@@@@@@@@@.
      @@@@@@@@@@@@@@@              &@@@@@@@
       @@@@@@@@@@@@@@@&            ,@@@@@.
         @@@@@@@@@@@@@@@           ,@@@@
          @@@@@@@@@@@@@@@(         ,@@/
           .@@@@@@@@@@@@@@@        ,@
             @@@@@@@@@@@@@@@.      .
              *@@@@@@@@@@@@@@@
                @@@@@@@@@@@@@@@.
                 &@@@@@@@@@@@@@@
                   @@@@@@@@@@@
                    @@@@@@@@%
                      @@@@@
                       @@*    VATZ dsrv labs Co., Ltd.

VATZ Version: go-lint-cc2becd
rootwarp@mindhack ~/g/d/vatz go-lint > make coverage
?       github.com/dsrvlabs/vatz        [no test files]
ok      github.com/dsrvlabs/vatz/cmd    2.676s  coverage: 19.8% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.013s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.007s  coverage: 79.4% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.029s  coverage: 7.8% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       0.009s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    0.009s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 2.509s  coverage: 51.1% of statements
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  0.009s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    1.010s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.006s  coverage: 7.1% of statements
rootwarp@mindhack ~/g/d/vatz go-lint >

Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xellos00 xellos00 merged commit f13d91b into dsrvlabs:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants