Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new flag --all on CLI command vatz init #457

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Add new flag --all on CLI command vatz init #457

merged 5 commits into from
Jun 1, 2023

Conversation

xellos00
Copy link
Member

…ing in config yaml file.

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.
Related: # (issue)
close #436

Summary
develop vatz init that provide official plugins default port numbers and name.

3. Comments

Please, leave a comments if there's further action that requires.

 dongyookang DK 💡   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-436-RE ±
 make coverage                                                                                                                           
fatal: No names found, cannot describe anything.
?       github.com/dsrvlabs/vatz        [no test files]
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/cmd    2.357s  coverage: 22.1% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.501s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.768s  coverage: 79.4% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.633s  coverage: 7.8% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       1.044s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    0.900s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 6.744s  coverage: 50.6% of statements
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  1.181s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    2.490s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.202s  coverage: 7.1% of statements
 dongyookang DK 💡   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-436-RE ±

@xellos00 xellos00 self-assigned this May 31, 2023
@xellos00 xellos00 added Vatz Project Name area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything labels May 31, 2023
@xellos00
Copy link
Member Author

@heejin-github
I will update port numbers when you finish issue

Please, let me know when you finish issue above.

heejin-github
heejin-github approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@heejin-github heejin-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootwarp
Copy link
Member 

ok      github.com/dsrvlabs/vatz/utils  0.006s
?       github.com/dsrvlabs/vatz        [no test files]
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/cmd    1.650s  coverage: 22.1% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.009s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.011s  coverage: 79.4% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.011s  coverage: 7.8% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       0.016s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    0.012s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 1.208s  coverage: 50.6% of statements
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  0.011s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    1.014s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.007s  coverage: 7.1% of statements
go build -ldflags="-X 'github.com/dsrvlabs/vatz/utils.Version=ISSUE-436-RE' -X 'github.com/dsrvlabs/vatz/utils.Commit=92c7ea9'" -v
github.com/dsrvlabs/vatz

@rootwarp
Copy link
Member

@xellos00
Could you please my comment from #458?
There is a bug to create template file and we need recover some codes.

@xellos00
Copy link
Member Author

@xellos00 Could you please my comment from #458? There is a bug to create template file and we need recover some codes.

I will raise a new PR that would recover issue #458.

This was referenced May 31, 2023
Merged
Merged
@xellos00
Copy link
Member Author

xellos00 commented May 31, 2023 •
edited
Loading

@xellos00 Could you please my comment from #458? There is a bug to create template file and we need recover some codes.

I will raise a new PR that would recover issue #458.

@rootwarp
This PR include --home on init.go

Can you review this PR?

@xellos00 xellos00 mentioned this pull request May 31, 2023
Merged
4 tasks
@rootwarp
Copy link
Member

rootwarp commented Jun 1, 2023 

rootwarp@mindhack ~/g/d/vatz ISSUE-436-RE > make coverage
?       github.com/dsrvlabs/vatz        [no test files]
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/cmd    1.576s  coverage: 23.5% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.008s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.011s  coverage: 79.4% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.011s  coverage: 7.8% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       0.014s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    0.011s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 1.417s  coverage: 50.6% of statements
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  0.009s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    1.014s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.007s  coverage: 7.1% of statements

rootwarp
rootwarp approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@rootwarp rootwarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xellos00 xellos00 merged commit 42742c6 into dsrvlabs:main Jun 1, 2023
@xellos00 xellos00 deleted the ISSUE-436-RE branch June 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heejin-github heejin-github heejin-github approved these changes

@rootwarp rootwarp rootwarp approved these changes

@hqueue hqueue Awaiting requested review from hqueue

@meetrick meetrick Awaiting requested review from meetrick

@kim201212 kim201212 Awaiting requested review from kim201212

@qkrybin qkrybin Awaiting requested review from qkrybin

@gnongs gnongs Awaiting requested review from gnongs

@skonhwang skonhwang Awaiting requested review from skonhwang

Assignees

@xellos00 xellos00

Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Config format
3 participants
@xellos00 @rootwarp @heejin-github