Fix lint in config, dispatcher #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ make coverage
? github.com/dsrvlabs/vatz [no test files]
# github.com/dsrvlabs/vatz/manager/plugin.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# github.com/dsrvlabs/vatz/cmd.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
ok github.com/dsrvlabs/vatz/cmd 7.287s coverage: 20.2% of statements
ok github.com/dsrvlabs/vatz/manager/api 1.071s coverage: 0.0% of statements [no tests to run]
ok github.com/dsrvlabs/vatz/manager/config 0.533s coverage: 77.8% of statements
ok github.com/dsrvlabs/vatz/manager/dispatcher 2.426s coverage: 7.2% of statements
ok github.com/dsrvlabs/vatz/manager/executor 1.389s coverage: 68.9% of statements
ok github.com/dsrvlabs/vatz/manager/healthcheck 2.069s coverage: 46.5% of statements
ok github.com/dsrvlabs/vatz/manager/plugin 15.692s coverage: 51.1% of statements
? github.com/dsrvlabs/vatz/manager/types [no test files]
? github.com/dsrvlabs/vatz/mocks [no test files]
ok github.com/dsrvlabs/vatz/monitoring/prometheus 1.705s coverage: 0.0% of statements
ok github.com/dsrvlabs/vatz/rpc 3.818s coverage: 67.2% of statements
ok github.com/dsrvlabs/vatz/utils 0.692s coverage: 7.1% of statements
|
kim201212
requested review from
xellos00,
rootwarp,
gnongs,
hqueue,
meetrick,
heejin-github and
skonhwang
|
@meetrick |
rootwarp
reviewed
Jun 1, 2023
gnongs
reviewed
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Type of change
Please delete options that are not relevant.
2. Summary
Related:
#344
Summary
Fix lint in config, dispatcher
3. Comments