Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate Lib API #58

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Auto generate Lib API #58

merged 3 commits into from
Dec 7, 2019

Conversation

kdheepak
Copy link
Member

@kdheepak kdheepak commented Dec 6, 2019

  • Set up script generate.jl to generate Lib C API from header file

Screen Shot 2019-12-06 at 1 57 05 PM

@kdheepak kdheepak requested review from PMeira and tshort December 6, 2019 20:58
@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #58 into master will decrease coverage by 2.96%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   71.89%   68.93%   -2.97%     
==========================================
  Files          43       44       +1     
  Lines        2807     2929     +122     
==========================================
+ Hits         2018     2019       +1     
- Misses        789      910     +121
Impacted Files Coverage Δ
src/lib.jl 57.33% <ø> (-4.61%) ⬇️
src/OpenDSSDirect.jl 86.66% <100%> (+0.95%) ⬆️
src/extensions.jl 46.15% <46.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dac5d6...c3b915a. Read the comment docs.

@tshort
Copy link
Collaborator

tshort commented Dec 7, 2019

Great idea! This'll help long-term maintenance. That's also the advantage of having a C interface library.

@kdheepak kdheepak merged commit 92569b7 into master Dec 7, 2019
@kdheepak kdheepak deleted the kd/auto-generate-lib-api branch December 7, 2019 04:38
@PMeira
Copy link
Member

PMeira commented Dec 7, 2019

Yes, this is great! This should be enough to allow testing the next major version of DSS C-API with minor changes to the rest of the Julia code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants