Allow generation of predicted measurement without measurement noise #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standardises the Updater.predict_measurement method to include an optional measurement_noise boolean argument to whether noise should be included in the predicted measurement. Defaults to True. Note this does change the default behaviour of particle filter, as that did not included noise by default before. As this isn't used in the update step, it'll only have an impact on data association stage. Resolves #961
sdhiscocks
requested review from
nperree-dstl and
mharris-dstl
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 93.56% 93.56% -0.01%
==========================================
Files 202 202
Lines 12985 13003 +18
Branches 2649 2656 +7
==========================================
+ Hits 12150 12166 +16
- Misses 591 592 +1
- Partials 244 245 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jswright-dstl
approved these changes
May 10, 2024
nperree-dstl
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardises the
Updater.predict_measurementmethod to include an optionalmeasurement_noiseBoolean argument to whether noise should be included in the predicted measurement. Defaults toTrue.Note this does change the default behaviour of particle filter, as that did not included noise by default before. As this isn't used in the update step, it'll only have an impact on data association stage.
Resolves #961