Set weakref to particle parent parent, rather than None #1044
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows references to be kept where parent parent remains in memory elsewhere, like track history. This covers additional cases from changes in #1023
sdhiscocks
requested review from
orosoman-dstl and
mharris-dstl
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 93.90% 93.94% +0.03%
==========================================
Files 204 204
Lines 13345 13357 +12
Branches 2730 2732 +2
==========================================
+ Hits 12532 12548 +16
+ Misses 551 549 -2
+ Partials 262 260 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jswright-dstl
approved these changes
Jun 17, 2024
spike-dstl
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows references to be kept where parent parent remains in memory elsewhere, like track history.
This covers additional cases from changes in #1023