Fix repr on Base class #1049
Merged
Fix repr on Base class #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new argument for fillvalue and indent that cause error is missing in some cases Primarily errors were with indent that was introduced in Python 3.12
sdhiscocks
requested review from
hpritchett-dstl and
orosoman-dstl
and removed request for
a team
jswright-dstl
approved these changes
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 204 204
Lines 13351 13353 +2
Branches 2731 2730 -1
=======================================
+ Hits 12562 12565 +3
Misses 533 533
+ Partials 256 255 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nperree-dstl
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new argument for fillvalue and indent that cause error if missing in some cases
Primarily errors were with indent that was introduced in Python 3.12