Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle distance of 0 correctly in TrackToTruth associator #1063

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

sdhiscocks
Copy link
Member

In edge case where distance was exactly zero, min_dist would evaluate false.

@sdhiscocks sdhiscocks added the bug label Jul 18, 2024
@sdhiscocks sdhiscocks requested a review from a team as a code owner July 18, 2024 15:19
@sdhiscocks sdhiscocks requested review from jswright-dstl and orosoman-dstl and removed request for a team July 18, 2024 15:19
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (e4e50ad) to head (3d4ad38).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   94.28%   94.28%   -0.01%     
==========================================
  Files         208      208              
  Lines       13604    13601       -3     
  Branches     2766     2765       -1     
==========================================
- Hits        12827    12824       -3     
  Misses        524      524              
  Partials      253      253              
Flag Coverage Δ
integration 67.18% <100.00%> (-0.03%) ⬇️
unittests 90.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In edge case where distance was exactly zero, min_dist would evaluate
false.
@sdhiscocks sdhiscocks force-pushed the TrackToTruth_mindist branch from 3cf825d to 3d4ad38 Compare July 19, 2024 07:22
@sdhiscocks sdhiscocks merged commit fdc5c5e into main Jul 24, 2024
10 checks passed
@sdhiscocks sdhiscocks deleted the TrackToTruth_mindist branch July 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants