Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLEAR MOT MetricGenerator #1068

Merged
merged 27 commits into from
Sep 10, 2024
Merged

Conversation

kopytjuk
Copy link
Contributor

This PR follows #1017 - where the association described in [1] is implemented.

Now we compute the actual MOTP and MOTA metrics:

image

[1] Evaluating Multiple Object Tracking Performance: The CLEAR MOT Metrics, Bernardin et al, 2008

@kopytjuk kopytjuk requested a review from a team as a code owner July 31, 2024 18:56
@kopytjuk kopytjuk requested review from jswright-dstl and orosoman-dstl and removed request for a team July 31, 2024 18:56
@kopytjuk kopytjuk force-pushed the add-clear-mot-metrics branch from a261367 to 9fde5fc Compare August 3, 2024 07:46
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 96.46018% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.33%. Comparing base (4b6bd37) to head (14b04e0).
Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
stonesoup/metricgenerator/clearmotmetrics.py 96.46% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   94.31%   94.33%   +0.01%     
==========================================
  Files         208      209       +1     
  Lines       13603    13716     +113     
  Branches     2767     2790      +23     
==========================================
+ Hits        12830    12939     +109     
- Misses        522      523       +1     
- Partials      251      254       +3     
Flag Coverage Δ
integration 66.84% <25.66%> (-0.35%) ⬇️
unittests 90.47% <96.46%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kopytjuk
Copy link
Contributor Author

kopytjuk commented Sep 1, 2024

Hey @sdhiscocks, since you reviewed a precursor PR on the associator logic - could you please take a look on this PR, which implements the actual metric?

Copy link
Member

@sdhiscocks sdhiscocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Looks good to me, with some minor suggestions. 👍

Will also need to add docs/source/stonesoup.metricgenerator.tracktotruthmetrics.rst file and toc tree entry in docs/source/stonesoup.metricgenerator.rst for docs to generate.

stonesoup/metricgenerator/clearmotmetrics.py Outdated Show resolved Hide resolved
stonesoup/metricgenerator/clearmotmetrics.py Outdated Show resolved Hide resolved
@kopytjuk
Copy link
Contributor Author

kopytjuk commented Sep 6, 2024

Thanks for the contribution. Looks good to me, with some minor suggestions. 👍

Will also need to add docs/source/stonesoup.metricgenerator.tracktotruthmetrics.rst file and toc tree entry in docs/source/stonesoup.metricgenerator.rst for docs to generate.

Done! Have also slightly adapted the class docstring for making it more consice and less verbose!

image

@sdhiscocks sdhiscocks merged commit 3cd4a8c into dstl:main Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants