Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to track to track association algorithm #634

Merged
merged 9 commits into from
May 20, 2022

Conversation

orosoman-dstl
Copy link
Contributor

I've made some improvements to the track to track association algorithm. The main difference is extra parameters allowing the user to specify whether the entire StateVector should be used, or rather just positional elements given in the mapping parameter. The class was also renamed in anticipation of new T2TA algorithms in Stone Soup

@orosoman-dstl orosoman-dstl requested a review from a team as a code owner May 9, 2022 17:34
@orosoman-dstl orosoman-dstl requested review from sdhiscocks and hpritchett-dstl and removed request for a team May 9, 2022 17:34
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #634 (d49d336) into main (c0bd5dd) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   94.22%   94.23%           
=======================================
  Files         158      158           
  Lines        7833     7853   +20     
  Branches     1506     1513    +7     
=======================================
+ Hits         7381     7400   +19     
  Misses        343      343           
- Partials      109      110    +1     
Flag Coverage Δ
integration 67.66% <15.62%> (-0.14%) ⬇️
unittests 91.99% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/measures.py 98.70% <ø> (ø)
stonesoup/dataassociator/tracktotrack.py 90.13% <87.50%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bd5dd...d49d336. Read the comment docs.

Copy link
Member

@sdhiscocks sdhiscocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an ability to provide mappings to measures, and I think this should be used instead. This changes also removes the ability to provide a custom measure, which may be desirable.

stonesoup/dataassociator/tracktotrack.py Outdated Show resolved Hide resolved
stonesoup/dataassociator/tracktotrack.py Outdated Show resolved Hide resolved
@orosoman-dstl orosoman-dstl force-pushed the improve_counting_t2t_association branch from 1ccc137 to 0a26364 Compare May 13, 2022 13:12
stonesoup/dataassociator/tracktotrack.py Outdated Show resolved Hide resolved
stonesoup/dataassociator/tracktotrack.py Outdated Show resolved Hide resolved
@sdhiscocks sdhiscocks added the breaking A breaking change that required other to modify their code label May 20, 2022
@sdhiscocks sdhiscocks merged commit 0e2d775 into main May 20, 2022
@sdhiscocks sdhiscocks deleted the improve_counting_t2t_association branch May 20, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change that required other to modify their code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants