Add max range to simple Radars #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes that do not fall within range of the radar
hpritchett-dstl
requested review from
sdhiscocks and
jswright-dstl
and removed request for
a team
sdhiscocks
reviewed
May 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 94.49% 94.50% +0.01%
==========================================
Files 168 168
Lines 8414 8430 +16
Branches 1625 1629 +4
==========================================
+ Hits 7951 7967 +16
Misses 345 345
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdhiscocks
approved these changes
May 20, 2022
jswright-dstl
approved these changes
May 20, 2022
hpritchett-dstl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the RadarBearingRange and RadarElevationBearingRange have no attribute to set its max range.
This PR adds a max_range, and adds in logic to only produce detections for states that lie within the sensor's FOV (similar to how RadarRotatingBearingRange does it).