-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Information Filter Tutorial #667
Conversation
Previously used state_vector which plotted the InformationState ellipses in the wrong location.
62308c7
to
e4a1659
Compare
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 94.55% 94.51% -0.04%
==========================================
Files 168 168
Lines 8441 8466 +25
Branches 1633 1635 +2
==========================================
+ Hits 7981 8002 +21
- Misses 343 345 +2
- Partials 117 119 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny documentation things to make it read a bit better but looks pretty good otherwise!
# Precision matrix - the inverse of the covariance matrix | ||
covar = np.diag([1.5, 0.5, 1.5, 0.5]) | ||
precision_matrix = np.linalg.inv(covar) # information matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we labelling this "precision matrix" or "information matrix"? Are they the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're actually the same thing. I'll add 'information matrix (precision matrix)' in place of the above comment to make it more coherent. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer precision matrix to avoid confusion with the matrix forms of Shannon and Fisher information (both of which are often referred to as information matrices). Our great sentience (i.e. wikipedia) also reckons it's precision: https://en.wikipedia.org/wiki/Covariance_matrix#Inverse_of_the_covariance_matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jordi. That's great, I'll change it to 'precision matrix'. Can't dispute wikipedia!
…ng attribute to use state.mean
7e23f90
to
1af26b4
Compare
Added Information Filter tutorial. Fixed plotting for information states. Added Gaussian interface to the InformationState.