Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Squared Mahalanobis distance and cache covariance matrix inversions #684

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

sdhiscocks
Copy link
Member

Multiple calls to Mahalanobis measure are common (e.g. comparing measurement predictions to detections), and by caching the matrix inversion, this can avoid repeating this costly operation.

Multiple calls to Mahalanobis measure are common (e.g. comparing
measurement predictions to detections), and by caching the matrix
inversion, this can avoid repeating this costly operation.
@sdhiscocks sdhiscocks requested a review from a team as a code owner August 3, 2022 08:51
@sdhiscocks sdhiscocks requested review from hpritchett-dstl and orosoman-dstl and removed request for a team August 3, 2022 08:51
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #684 (0391745) into main (bfbe6ec) will decrease coverage by 0.00%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   94.60%   94.60%   -0.01%     
==========================================
  Files         170      170              
  Lines        8548     8563      +15     
  Branches     1654     1657       +3     
==========================================
+ Hits         8087     8101      +14     
  Misses        342      342              
- Partials      119      120       +1     
Flag Coverage Δ
integration 68.53% <76.00%> (+0.02%) ⬆️
unittests 92.11% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/measures.py 97.95% <95.45%> (-0.84%) ⬇️
stonesoup/mixturereducer/gaussianmixture.py 96.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbe6ec...0391745. Read the comment docs.

@sdhiscocks sdhiscocks merged commit 636610c into main Aug 9, 2022
@sdhiscocks sdhiscocks deleted the square_mah_cache branch August 9, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants