Add instance check for reward function #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswright-dstl
requested review from
sdhiscocks and
orosoman-dstl
and removed request for
a team
jswright-dstl
force-pushed
the
reward
branch
from
9a81537 to
49b82ba
Compare
Current reward function assumes a single detection per track This adds an instance check to manage clutter.
jswright-dstl
force-pushed
the
reward
branch
from
49b82ba to
a6c1033
Compare
sdhiscocks
approved these changes
Sep 22, 2022
sdhiscocks
approved these changes
Sep 22, 2022
Codecov ReportBase: 94.66% // Head: 94.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 171 171
Lines 8773 8774 +1
Branches 1707 1707
=======================================
+ Hits 8305 8306 +1
Misses 342 342
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
orosoman-dstl
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current reward function assumes a single detection per track. This adds an instance check to manage when clutter (or non TrueDetection types) is present.