Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generic readers for HDF5 #731

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Implement generic readers for HDF5 #731

merged 5 commits into from
Oct 3, 2022

Conversation

cpbrophy
Copy link
Contributor

Borrowed from the generic CSV readers to support HDF5 files, adding the option to reduce the resolution of time fields while reading data in.

Borrowed from the generic CSV readers to support HDF5 files, adding the option to reduce the resolution of time fields while reading data in.
@cpbrophy cpbrophy requested a review from a team as a code owner September 29, 2022 17:11
@cpbrophy cpbrophy requested review from sdhiscocks and hpritchett-dstl and removed request for a team September 29, 2022 17:11
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 94.79% // Head: 94.85% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (d406d8e) compared to base (8e2bb62).
Patch coverage: 98.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   94.79%   94.85%   +0.05%     
==========================================
  Files         168      169       +1     
  Lines        8190     8275      +85     
  Branches     1560     1581      +21     
==========================================
+ Hits         7764     7849      +85     
+ Misses        317      316       -1     
- Partials      109      110       +1     
Flag Coverage Δ
integration 69.02% <35.29%> (-0.37%) ⬇️
unittests 92.65% <98.82%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stonesoup/reader/hdf5.py 98.82% <98.82%> (ø)
stonesoup/reader/file.py 93.75% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sdhiscocks sdhiscocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. PR looks great 👍 Just needs one change to include new module in documentation:

diff --git a/docs/source/stonesoup.reader.rst b/docs/source/stonesoup.reader.rst
index ad668da2..b1f96573 100644
--- a/docs/source/stonesoup.reader.rst
+++ b/docs/source/stonesoup.reader.rst
@@ -20,6 +20,11 @@ YAML
 .. automodule:: stonesoup.reader.yaml
     :show-inheritance:
 
+HDF5
+----
+.. automodule:: stonesoup.reader.hdf5
+    :show-inheritance:
+
 AISHub
 ------
 .. automodule:: stonesoup.reader.aishub

stonesoup/reader/hdf5.py Outdated Show resolved Hide resolved
@sdhiscocks sdhiscocks merged commit f6d7559 into dstl:main Oct 3, 2022
@cpbrophy cpbrophy deleted the hdf5 branch October 4, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants