TimeBasedPlotter default timestamps and Notebook animation docs #751
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no longer requires specifying the time stamps, as they default to those from data being plotted
Also ignore example gif file that is saved.
sdhiscocks
requested review from
jswright-dstl and
hpritchett-dstl
and removed request for
a team and
jswright-dstl
Codecov ReportBase: 94.92% // Head: 94.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 171 171
Lines 8454 8454
Branches 1232 1232
=======================================
Hits 8025 8025
Misses 317 317
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jswright-dstl
approved these changes
Nov 28, 2022
gawebb-dstl
approved these changes
Nov 29, 2022
|
|
||
| ani = plotter.run(times_to_plot, plot_item_expiry=datetime.timedelta(seconds=60)) | ||
| plt.show() | ||
| plotter.run(plot_item_expiry=datetime.timedelta(seconds=60)) | ||
|
|
There was a problem hiding this comment.
Suggested change
| matplotlib.pyplot.show() |
This makes the animation appear, when ran from the command line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This no longer requires specifying the time stamps, as they default to
those from data being plotted
Also ignore example gif file that is saved.