Fix covar for ConstantNthDerivative model #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed covar calculation of constant nth derivative. Line 150 had “N**2”, corrected to “N*2”.
KaidosUncle
requested review from
sdhiscocks and
nperree-dstl
and removed request for
a team
sdhiscocks
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks @KaidosUncle. I verified by calculating out Constant Jerk model (as CA and below are the same) your change is correct.
sdhiscocks
changed the title
jswright-dstl
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed covar calculation of constant nth derivative. Line 150 had “N**2”, corrected to “N*2”.