-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track stitching class and example. #764
Conversation
Co-authored-by: Scott Florence <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 94.69% 94.76% +0.07%
==========================================
Files 174 175 +1
Lines 9194 9375 +181
Branches 1413 1474 +61
==========================================
+ Hits 8706 8884 +178
Misses 349 349
- Partials 139 142 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Code coverage could be improved. It looks like the backwards methods aren't tested currently. |
if metric.startswith("SIAP") and not metric.endswith(" at times")} | ||
siap_time_based = {metrics.get(metric) for metric in metrics if metric.endswith(' at times')} | ||
|
||
_ = SIAPTableGenerator(siap_averages).compute_metric() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to compare before and after, but I can see issue is that stitched tracks aren't interpolated. Probably should add that as separate component that could be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected some typos and made some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions for some text changes and legacy comments to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor corrections and one suggestion for text deletion.
# %% | ||
# Track Stitcher Class | ||
# ^^^^^^^^^^^^^^^^^^^^ | ||
# The cell below contains the track stitcher class. The functions `forward_predict` and | ||
# `backward_predict` perform the forward and backward predictions respectively (as noted above). If | ||
# using fowards and backwards stitching, predictions from both methods are merged together. | ||
# They calculate which pairs of tracks could possibly be stitched together. The function `stitch` | ||
# uses `forward_predict` and `backward_predict` to pair and 'stitch' track sections together. | ||
|
||
from stonesoup.stitcher import TrackStitcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could delete this text as most content is covered in the intro and move the import statement down to applying the stitcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor corrections and one suggestion for text deletion.
|
Co-authored-by: Roisín Gorman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good
Co-authored-by: Scott Florence [email protected]
Pull request to add track stitching example and 'Stitcher' class to main stone soup repository.