Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_clutter_detectable method to sensors #787

Merged
merged 4 commits into from
May 16, 2023
Merged

Add is_clutter_detectable method to sensors #787

merged 4 commits into from
May 16, 2023

Conversation

jswright-dstl
Copy link
Contributor

Used to detect if clutter generated by the ClutterModel is in the FOV.

Resolves #781

@jswright-dstl jswright-dstl requested a review from a team as a code owner April 3, 2023 14:28
@jswright-dstl jswright-dstl requested review from sdhiscocks and removed request for a team April 3, 2023 14:28
Copy link
Contributor

@mharris-dstl mharris-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfied with changes made after having a conversation with jswright.

@mharris-dstl mharris-dstl self-requested a review April 18, 2023 10:48
Used to detect if clutter generated by the ClutterModel is in the FOV.
Certain sensors have a FOV where the clutter measurement space can be
calculated as to if the clutter is within the FOV or not, as such,
cluter measurements can be generated outside the FOV and thus removed
from the set of clutter measurements. This means a single TrueDetection
combined with a set of clutter measurements where all are outside the
FOV returns a single TrueDetection.
@jswright-dstl jswright-dstl changed the title Add Detection type to is_detectable method Add is_clutter_detectable method May 2, 2023
Copy link
Contributor

@mharris-dstl mharris-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job and doesn't break the tutorials like the first implementation did.

@sdhiscocks sdhiscocks changed the title Add is_clutter_detectable method Add is_clutter_detectable method to sensors May 16, 2023
@sdhiscocks sdhiscocks merged commit 689821a into main May 16, 2023
@sdhiscocks sdhiscocks deleted the clutter_fov branch May 16, 2023 09:37
@sdhiscocks sdhiscocks added the bug label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensor clutter appears outside sensor's FOV
3 participants