-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_clutter_detectable method to sensors #787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharris-dstl
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Satisfied with changes made after having a conversation with jswright.
Used to detect if clutter generated by the ClutterModel is in the FOV.
Certain sensors have a FOV where the clutter measurement space can be calculated as to if the clutter is within the FOV or not, as such, cluter measurements can be generated outside the FOV and thus removed from the set of clutter measurements. This means a single TrueDetection combined with a set of clutter measurements where all are outside the FOV returns a single TrueDetection.
jswright-dstl
changed the title
Add Detection type to is_detectable method
Add is_clutter_detectable method
May 2, 2023
mharris-dstl
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the job and doesn't break the tutorials like the first implementation did.
sdhiscocks
changed the title
Add is_clutter_detectable method
Add is_clutter_detectable method to sensors
May 16, 2023
sdhiscocks
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to detect if clutter generated by the ClutterModel is in the FOV.
Resolves #781