-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resampling methods and example #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ESSResampler. Progress on resampler example doc.
…o ESSResampler. Progress on resampler example doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly adding . to all the classes
jswright-dstl
requested changes
Jul 14, 2023
Co-authored-by: James Wright <[email protected]>
Co-authored-by: rg <[email protected]>
orosoman-dstl
requested changes
Jul 28, 2023
Co-authored-by: Oliver Rosoman <[email protected]>
rcgorman-dstl
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments to review. otherwise the updates look great and the explanations are much clearer :)
rcgorman-dstl
approved these changes
Aug 4, 2023
orosoman-dstl
approved these changes
Aug 8, 2023
jswright-dstl
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new resampling methods:
- StratifiedResampler
- MultinomialResampler
- ResidualResampler
Added new example document covering all resampling methods.
Minor adjustment to fix error in ESS section of tutorial 4 (error made by me).
Change to how ESSResampler calls its resample function to allow properties to be given to it's sub-resampler.