Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resampling methods and example #817

Merged
merged 47 commits into from
Aug 9, 2023
Merged

New resampling methods and example #817

merged 47 commits into from
Aug 9, 2023

Conversation

spike-dstl
Copy link
Contributor

  • Introduced new resampling methods:
    - StratifiedResampler
    - MultinomialResampler
    - ResidualResampler

  • Added new example document covering all resampling methods.

  • Minor adjustment to fix error in ESS section of tutorial 4 (error made by me).

  • Change to how ESSResampler calls its resample function to allow properties to be given to it's sub-resampler.

@spike-dstl spike-dstl requested a review from rcgorman-dstl June 20, 2023 13:16
@spike-dstl spike-dstl requested a review from a team as a code owner June 20, 2023 13:16
@spike-dstl spike-dstl requested review from orosoman-dstl and removed request for a team June 20, 2023 13:16
Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly adding . to all the classes

docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/04_ParticleFilter.py Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
stonesoup/resampler/particle.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments to review. otherwise the updates look great and the explanations are much clearer :)

docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
docs/tutorials/sampling/ResamplingTutorial.py Outdated Show resolved Hide resolved
@sdhiscocks sdhiscocks merged commit ce4114a into main Aug 9, 2023
@sdhiscocks sdhiscocks deleted the new_resampling_methods branch August 9, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants