Fix recursion error when printing objects #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sglvladi
requested review from
hpritchett-dstl and
mharris-dstl
and removed request for
a team
orosoman-dstl
approved these changes
Jul 28, 2023
sglvladi
force-pushed
the
fix_whitespace_recursion_error
branch
from
6eb29a4 to
55d09e8
Compare
|
@orosoman-dstl I realised there was a cleaner way to code it, hence the new commit. Please check to make sure you are still happy |
sdhiscocks
approved these changes
Aug 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #831 by avoiding the recursive call to
BaseRepr.whitespace_remove().