-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create IsotropicPlume model and gas sensor #850
Merged
sdhiscocks
merged 13 commits into
dstl:main
from
timothy-glover:create_gas_model_and_sensor
Dec 8, 2023
Merged
Create IsotropicPlume model and gas sensor #850
sdhiscocks
merged 13 commits into
dstl:main
from
timothy-glover:create_gas_model_and_sensor
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothy-glover
requested review from
sdhiscocks and
orosoman-dstl
and removed request for
a team
September 4, 2023 12:57
I am unsure why the docs are not building correctly. It seems to be referring to the GMPHD tutorial plotting style in the error. The docs build without any warnings or errors on my PC. |
sdhiscocks
approved these changes
Oct 25, 2023
Co-authored-by: Steven Hiscocks <[email protected]>
Co-authored-by: Steven Hiscocks <[email protected]>
Co-authored-by: Steven Hiscocks <[email protected]>
Co-authored-by: Steven Hiscocks <[email protected]>
nperree-dstl
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
IsotropicPlume
model for calculating gas concentration at a location based on a source term. The model implements the isotropic plume method from the literature (reference in docs) as well as specific likelihood function for evaluating measurement likelihood. This is also based on work presented in literature, with some modifications to account for the fact that this is a simulated sensor with more ideal characteristics than a real sensor. Documentation has been created including the main functions behind the model.A gas sensor has also been created to carry the
IsotropicPlume
model that can (and will) be used for a later sensor management example.A repository in MATLAB on which this PR is based can be seen at: https://github.com/Cunjia-Liu/AutoSTE