-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an example comparing Particle filters and kalman filters using track fusion #875
Conversation
track_fusion_tracker.detector = Tracks2GaussianDetectionFeeder(dummy_detector_KF) | ||
track_fusion_tracker.__iter__() | ||
_, tracks = next(track_fusion_tracker) | ||
KF_fused_track.update(tracks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing the first cell at the start of Section "3) Run the trackers..." to fail on build with the following errors;
On CircleCI "ValueError: Mime type rendering requires ipython but it is not installed"
On local build "ValueError: All detections must have the same timestamp"
…he PF and the KF, added the change in the feeder tracking for track fusion, it works ok
… and example like
2d4aa6e
to
844cef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to improve overall readability but the key thing is the comment on lines 553-554 which I think is what is causing the docs to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation renders correctly now, just a couple more minor comments/suggestions but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed one more inconsistency in documentation but otherwise happy!
plotter.fig | ||
|
||
# %% | ||
# 2) Initialise the trackers components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# 2) Initialise the trackers components | |
# 2. Initialise the trackers components |
This PR adds an example were we do tracking fusion using partial tracks obtained by different sensors and compares how an Extended Kalman filter results are similar or different to a Particle filter.
This PR also adds a solution to use
Tracks2GaussianDetectionFeeder
for Particle States (and not only Gaussian states) as discussed and solved in #854I will add further examples (or enhance this one) regarding track fusion when other algorithms are presented (Covariance inflation)