Modify Ensemble state generation and initiator test thresholds #902
+26
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification makes this method similar to other sampling done in models, as well as supporting custom data types (e.g. Bearing) properly.
sdhiscocks
requested review from
nperree-dstl and
spike-dstl
and removed request for
a team
jswright-dstl
approved these changes
Dec 12, 2023
nperree-dstl
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase tolerance on initiator test for ensemble filter, as these were failing fairly frequently due to random sampling.
Modification for sampling on Ensemble state makes it similar to other sampling done in models, as well as supporting custom data types (e.g. Bearing) properly.