Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hash Functions to TimeRange and CompoundTimeRange #981

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

gawebb-dstl
Copy link
Contributor

Hash functions were added to TimeRange and CompoundTimeRange. The hash functions weren't inherrited from Interval/s (See reason below). Some type annotation was also added.

From Python docs: A class that overrides eq() and does not define hash() will have its hash() implicitly set to None.

@gawebb-dstl gawebb-dstl added the bug label Apr 9, 2024
@gawebb-dstl gawebb-dstl requested a review from a team as a code owner April 9, 2024 13:49
@gawebb-dstl gawebb-dstl requested review from sdhiscocks and nperree-dstl and removed request for a team April 9, 2024 13:49
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.50%. Comparing base (8c8f9ee) to head (f5f95ec).

Files Patch % Lines
stonesoup/types/time.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   93.54%   93.50%   -0.05%     
==========================================
  Files         202      202              
  Lines       12930    12935       +5     
  Branches     2640     2640              
==========================================
- Hits        12096    12095       -1     
- Misses        590      594       +4     
- Partials      244      246       +2     
Flag Coverage Δ
integration 66.05% <85.71%> (+<0.01%) ⬆️
unittests 89.16% <85.71%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdhiscocks sdhiscocks merged commit 03679c4 into main Apr 10, 2024
9 of 10 checks passed
@sdhiscocks sdhiscocks deleted the time_range_hash_bugfix branch April 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants