Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plotterly to name axes being plotted #988

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Update Plotterly to name axes being plotted #988

merged 3 commits into from
Apr 23, 2024

Conversation

jswright-dstl
Copy link
Contributor

This PR adds the functionality to include axis labels when plotting non-xy plots, e.g., plotting y against z.

Currently all plots default to have axis names "x" and "y" regardless of the dimensions being plotted.

@jswright-dstl jswright-dstl requested a review from a team as a code owner April 22, 2024 12:47
@jswright-dstl jswright-dstl requested review from sdhiscocks and spike-dstl and removed request for a team April 22, 2024 12:47
@jswright-dstl jswright-dstl changed the title Update Plotterly tio name axis Update Plotterly to name axis being plotted Apr 22, 2024
@jswright-dstl jswright-dstl changed the title Update Plotterly to name axis being plotted Update Plotterly to name axes being plotted Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (c850649) to head (43462f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   93.56%   93.53%   -0.03%     
==========================================
  Files         202      202              
  Lines       12939    12941       +2     
  Branches     2643     2644       +1     
==========================================
- Hits        12107    12105       -2     
- Misses        589      591       +2     
- Partials      243      245       +2     
Flag Coverage Δ
integration 66.26% <100.00%> (-0.02%) ⬇️
unittests 89.12% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdhiscocks sdhiscocks merged commit 3467c9f into main Apr 23, 2024
@sdhiscocks sdhiscocks deleted the plotly_axis branch April 23, 2024 08:18
@sdhiscocks sdhiscocks added the bug label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants